flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

Implement Github workflows for C# PHPand JS

Open dbaileychess opened this issue 3 years ago • 3 comments
trafficstars

I removed some commented out workflows for C#, PHP, and JS in https://github.com/google/flatbuffers/pull/6948, they should be implemented at some point. This is to track that work and point to the code that was removed.

dbaileychess avatar Dec 01 '21 07:12 dbaileychess

C# is done.

dbaileychess avatar Dec 14 '21 05:12 dbaileychess

JS should be covered: https://github.com/google/flatbuffers/blob/master/.github/workflows/build.yml#L449-L463

@bjornharrtell do we need explicit JS testing?

dbaileychess avatar Sep 13 '22 06:09 dbaileychess

@dbaileychess not at this time. The current tests does test JavaScript in the "modern way" i.e via individual ES modules (transpiled from TS).

However, if/when we can get https://github.com/google/flatbuffers/issues/7426 and https://github.com/google/flatbuffers/issues/7448 resolved that could warrant a second test run on those artifacts which would be the same tests but against "old school non modular single file built JavaScript".

bjornharrtell avatar Sep 13 '22 18:09 bjornharrtell

This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

github-actions[bot] avatar Mar 14 '23 20:03 github-actions[bot]

This issue was automatically closed due to no activity for 6 months plus the 14 day notice period.

github-actions[bot] avatar Mar 29 '23 20:03 github-actions[bot]