flatbuffers
flatbuffers copied to clipboard
Implement Github workflows for C# PHPand JS
I removed some commented out workflows for C#, PHP, and JS in https://github.com/google/flatbuffers/pull/6948, they should be implemented at some point. This is to track that work and point to the code that was removed.
C# is done.
JS should be covered: https://github.com/google/flatbuffers/blob/master/.github/workflows/build.yml#L449-L463
@bjornharrtell do we need explicit JS testing?
@dbaileychess not at this time. The current tests does test JavaScript in the "modern way" i.e via individual ES modules (transpiled from TS).
However, if/when we can get https://github.com/google/flatbuffers/issues/7426 and https://github.com/google/flatbuffers/issues/7448 resolved that could warrant a second test run on those artifacts which would be the same tests but against "old school non modular single file built JavaScript".
This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.
This issue was automatically closed due to no activity for 6 months plus the 14 day notice period.