flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

Make clean removes checked in generated files

Open dbaileychess opened this issue 4 years ago • 3 comments

Running make clean deletes a bunch of files that are purposely checked into the repo. We should avoid deleting them in the clean step.

deleted:    samples/monster.bfbs
deleted:    samples/monster_generated.h
deleted:    tests/arrays_test.bfbs
deleted:    tests/arrays_test_generated.h
deleted:    tests/monster_extra_generated.h
deleted:    tests/monster_test.bfbs
deleted:    tests/monster_test_bfbs_generated.h
deleted:    tests/monster_test_generated.h
deleted:    tests/namespace_test/namespace_test1_generated.h
deleted:    tests/namespace_test/namespace_test2_generated.h
deleted:    tests/native_type_test_generated.h
deleted:    tests/optional_scalars_generated.h
deleted:    tests/union_vector/union_vector_generated.h

dbaileychess avatar Sep 22 '21 16:09 dbaileychess

I am guessing CMake assumes that anything that is generated by its step is a temp build file and should thus be deleted?

aardappel avatar Sep 23 '21 19:09 aardappel

Yeah, i think have to add these as dependencies to some target so they don't get deleted.

dbaileychess avatar Sep 23 '21 20:09 dbaileychess

This issue is stale because it has been open 6 months with no activity. Please comment or this will be closed in 14 days.

github-actions[bot] avatar Mar 25 '22 20:03 github-actions[bot]