flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

Vector union not supported Python [Python, OS X, master]

Open InvaderGir1 opened this issue 6 years ago • 15 comments

Hello,

I was wondering when will vector unions will be available in python?

Thanks.

InvaderGir1 avatar Dec 06 '17 13:12 InvaderGir1

I don't know of anyone working on it at the moment.

aardappel avatar Dec 07 '17 18:12 aardappel

Is there a plan to implement this feature for Python as well or is anyone working on it?

grhasgf avatar Dec 28 '18 12:12 grhasgf

This issue has been automatically marked as stale because it has not had activity for 6 months. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 27 '19 01:07 stale[bot]

Any updates on this feature?

yeralin avatar Apr 20 '20 19:04 yeralin

Feature needed here ;)

ftwftw0 avatar Aug 17 '20 16:08 ftwftw0

Needed here too 😃

joseprupi avatar Feb 26 '21 13:02 joseprupi

I need this too. @aardappel Would you be willing to accept PRs?

sheinbergon avatar Aug 10 '21 08:08 sheinbergon

@sheinbergon yes, a PR would be great!

aardappel avatar Aug 12 '21 20:08 aardappel

Yes we are running into the lack of support of vector of unions in Python as well. Any updates? Can we help?

jeroenbouma avatar Aug 16 '21 10:08 jeroenbouma

@jeroenbouma the best way to help would be to write a PR, but it seems @sheinbergon might want to work on it too

CasperN avatar Aug 16 '21 17:08 CasperN

This issue is stale because it has been open 6 months with no activity. Please comment or this will be closed in 14 days.

github-actions[bot] avatar Feb 15 '22 20:02 github-actions[bot]

Finally have the time to take a crack at it. You can expect a PR soon :smile:

sheinbergon avatar Apr 13 '22 11:04 sheinbergon

@sheinbergon Did you take a look at this?

surculus12 avatar Jun 25 '22 15:06 surculus12

@surculus12 yes I did.

Unfortunately, the C++ flatc compiler code structure was not a "smooth ride" getting into (partially due to the fact I'm not much of c++ dev, and this kind mazy string concat code can be a bit hard to follow ). Then, other open-source efforts got a higher priority and I had to take a step back again.

I did notice a somewhat preliminary feature is missing - support for struct/strict union types (non-vector related). So I will be implementing that first (hopefully this week).

Once I'm done with that, I'll hopefully be more comfortable with tackling the bigger vector of union feature.

sheinbergon avatar Jun 26 '22 08:06 sheinbergon

@sheinbergon No worries. I took a look and added support in PR #7371.

surculus12 avatar Jun 27 '22 16:06 surculus12