filament icon indicating copy to clipboard operation
filament copied to clipboard

Fix issue where material instance name cannot be set without creating a default instance

Open kunyoungparkk opened this issue 1 year ago • 2 comments

This PR is related to PR #8147

After applying PR #8147, FMaterial::createInstance has an issue where it ignores the name passed as a parameter when mDefaultMaterialInstance is not set.

By applying this PR, a material instance can be assigned a name even if mDefaultMaterialInstance is not set.

kunyoungparkk avatar Oct 18 '24 09:10 kunyoungparkk

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 18 '24 09:10 google-cla[bot]

@kunyoungparkk would you be able to sign the CLA so we can merge this change? Thank you!

pixelflinger avatar Oct 18 '24 17:10 pixelflinger

@kunyoungparkk windows build is failing

pixelflinger avatar Oct 21 '24 18:10 pixelflinger

@kunyoungparkk windows build is failing

I’m currently investigating the issue as the build is working fine in my local Windows environment. It might take some time to identify the root cause. I appreciate your patience, and I will provide an update once the issue is resolved.

kunyoungparkk avatar Oct 22 '24 05:10 kunyoungparkk