filament icon indicating copy to clipboard operation
filament copied to clipboard

Add public API in View for transparent picking

Open show50726 opened this issue 1 year ago • 1 comments

Blocked by #8190

Close #6614

This change is tested in https://github.com/show50726/filament/tree/dev/picking-test-env

show50726 avatar Oct 17 '24 12:10 show50726

You also need to add the Java APIs as well as the Javascript ones (in js-bindings.cpp)

Done. I didn't notice that, thanks for the reminder:D

BTW, I noticed that there are some functions in View are not added to jsbindings.cpp (ex. View::setFrontFaceWindingInverted). I'm wondering if that is on purpose? or some functions are missed and it would need a PR to fix them? Thanks!

show50726 avatar Oct 18 '24 15:10 show50726

Thank you for this pull request. Awaiting for this feature also.

olenev avatar Oct 21 '24 09:10 olenev

You also need to add the Java APIs as well as the Javascript ones (in js-bindings.cpp)

Done. I didn't notice that, thanks for the reminder:D

BTW, I noticed that there are some functions in View are not added to jsbindings.cpp (ex. View::setFrontFaceWindingInverted). I'm wondering if that is on purpose? or some functions are missed and it would need a PR to fix them? Thanks!

yes I think we are missing a lot of stuff. unfortunately this process is manual and we have missed some in the past.

pixelflinger avatar Oct 22 '24 17:10 pixelflinger

@show50726 could you please check that by default transparent materials not picking? Because I test it on my model with transparent materials and if I set setTransparentPickingEnabled(boolean enabled) to false or event don't set it all, I am still able to select it.

olenev avatar Oct 23 '24 10:10 olenev

@show50726 could you please check that by default transparent materials not picking? Because I test it on my model with transparent materials and if I set setTransparentPickingEnabled(boolean enabled) to false or event don't set it all, I am still able to select it.

Hello @olenev, Could you provide which platform you are working on, and how do you configure material, or even better, a public branch where I can try it directly?

I tried it before making this PR and I did not see this problem, so I’d like to know about your configuration. Thanks!

show50726 avatar Oct 23 '24 10:10 show50726

Could you provide which platform you are working on, and how do you configure material, or even better, a public branch where I can try it directly?

@show50726 thank you. I using filament on Android project (Java, Kotlin). I will try to prepare test project tomorrow with part of my model to reproduce this issue.

olenev avatar Oct 23 '24 11:10 olenev