KHR_materials_Specular

[PsycoTodd]

This branch contains the change for KHR_materials_specular support. Tested on test model and some edtited models.

For android, due to level support, we force material changes as below:

1. KHR_materials_unlit and KHR_materials_specular, the ulit is dropped.
2. KHR_materials_specular but we also have clearcoat normal texture or clear coat roghness texture, in this case we drop the latter two.
3. KHR_materials_sheen and we have specular color texture, in this case we drop specular color texture.
4. KHR_materials_volume and has specular color texture, in this case we drop specular color texture.

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[PsycoTodd]

I have pushed change in google/draco so not sure if I still need to sign the form again?

[pixelflinger]

@PsycoTodd would you be able to update the branch? I would like to try and get this PR in again. thanks!

[PsycoTodd]

Trying this weekend. Will let u know how it goes

On Wed, May 29, 2024 at 12:11 PM Mathias Agopian @.***> wrote:

@PsycoTodd https://github.com/PsycoTodd would you be able to update the branch? I would like to try and get this PR in again. thanks!

— Reply to this email directly, view it on GitHub https://github.com/google/filament/pull/7564#issuecomment-2138089166, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCQBDW2VPZONSAMV3TPHGLZEYR4VAVCNFSM6AAAAABDAO4VI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYGA4DSMJWGY . You are receiving this because you were mentioned.Message ID: @.***>

[PsycoTodd]

Merged my change from the current mainline and have the pull request.

[PsycoTodd]

Will the readme and version update by someone else? I think some release job need to be done from the team?

[pixelflinger]

@PsycoTodd would you be able to rebase this PR one more time (it has conflicts again), I'll try to merge it this week.

[PsycoTodd]

sure, let me do this. And I suppose I need also update the readme a little bit to include the extension support announcement.

On Tue, Jun 18, 2024 at 12:08 AM Mathias Agopian @.***> wrote:

@PsycoTodd https://github.com/PsycoTodd would you be able to rebase this PR one more time (it has conflicts again), I'll try to merge it this week.

— Reply to this email directly, view it on GitHub https://github.com/google/filament/pull/7564#issuecomment-2175326238, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCQBDWJ2G45QZ6KNV6FCILZH7MIVAVCNFSM6AAAAABDAO4VI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZVGMZDMMRTHA . You are receiving this because you were mentioned.Message ID: @.***>