filament icon indicating copy to clipboard operation
filament copied to clipboard

tabs for matdbg

Open pixelflinger opened this issue 5 years ago • 3 comments

It would be nice if matdbg could open shaders in a tab, so it's easy to go back and forth between a few shaders.

pixelflinger avatar Jun 13 '20 00:06 pixelflinger

I received an email for the comment from André Perez, but I don't see his comment on the Issue page. Very strange.

Anyway, to answer the question: resizeable panes would be nice but I don't think we're very interested in purely cosmetic improvements if they involve adding new libraries to matdbg or increasing its complexity.

On Sun, Sep 27, 2020 at 8:18 AM André Perez [email protected] wrote:

Hi, @romainguy https://github.com/romainguy, @pixelflinger https://github.com/pixelflinger and @prideout https://github.com/prideout. I wonder if I could give some style to matdbg, using the Material Components for the web https://material-components.github.io/material-components-web-catalog.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/filament/issues/2683#issuecomment-699648333, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ2VSCK7I3247Z2M3B4TSLSH5JUFANCNFSM4N4XYHCQ .

prideout avatar Sep 27 '20 17:09 prideout

@prideout, I was thinking in a simple style by using the following links: https://unpkg.com/material-components-web@latest/dist/material-components-web.min.css https://unpkg.com/material-components-web@latest/dist/material-components-web.min.js

Also, I wonder if I could try to use AngularJS instead of Mustache. May I try and open the PR, so you could say what you think?

andreperezmaselco avatar Sep 27 '20 21:09 andreperezmaselco

Yes, feel free to open a PR, thanks!

prideout avatar Sep 28 '20 15:09 prideout

We are working on a FrameGraph debugger, that's probably higher priority.

prideout avatar Nov 01 '22 18:11 prideout