extra-keyboards-for-chrome-os icon indicating copy to clipboard operation
extra-keyboards-for-chrome-os copied to clipboard

Added Asset-Nior [en] layout

Open indigoferra opened this issue 6 years ago • 15 comments

A lesser known keyboard layout which I use exclusively. Might as well add it in the chromeOS repo :).

This is such a small addition. Let me know if there is anything I could do to improve this release.

More info on Asset-Nior http://millikeys.sourceforge.net/asset/

indigoferra avatar Nov 29 '18 22:11 indigoferra

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Nov 29 '18 22:11 googlebot

I signed it!

indigoferra avatar Nov 29 '18 22:11 indigoferra

CLAs look good, thanks!

googlebot avatar Nov 29 '18 22:11 googlebot

@darkenvy are you still interested in merging this PR?

bderrly avatar Sep 19 '20 01:09 bderrly

@darkenvy are you still interested in merging this PR?

Yes. Let me see what I can do about those changes :)

indigoferra avatar Sep 19 '20 18:09 indigoferra

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Sep 28 '20 19:09 google-cla[bot]

Updated MR and tested layout on ChromiumOS. All good to go :). @bderrly, do you know if there is a way to override caps-lock? This keyboard layout uses caps-lock for backspace.

indigoferra avatar Sep 28 '20 19:09 indigoferra

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Sep 28 '20 19:09 google-cla[bot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Sep 28 '20 19:09 google-cla[bot]

@googlebot I fixed it.

indigoferra avatar Sep 28 '20 19:09 indigoferra

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Sep 28 '20 19:09 google-cla[bot]

@googlebot I fixed it.

indigoferra avatar Sep 28 '20 19:09 indigoferra

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Sep 28 '20 19:09 google-cla[bot]

@bderrly, github says that there is "1 change requested" but I double checked and believe I got all of them. :)

indigoferra avatar Jan 15 '21 19:01 indigoferra

With apologies for the extended silence; I'm trying to pick up state on this project now and figure out how everything works. There's a small group of people in Google who still have access to the release keys etc.

@darkenvy Were you able to get Googlebot to recognize your CLA?

colmbuckley avatar Jan 20 '22 10:01 colmbuckley