exposure-notifications-android icon indicating copy to clipboard operation
exposure-notifications-android copied to clipboard

Sample code could be more representative of real-life Android code

Open hvisser opened this issue 5 years ago • 2 comments

This is more of a remark than a bug as the code is functional as is.

The sample code makes heavy use of ListenableFuture, Guava and is Java based.

I understand that this is according to Google internal standards, but most Android apps are build with Kotlin ("Kotlin first") and use primitives like coroutines or RxJava for async work.

To further clarify: the most important parts for me are the interactions with the API. The ListenableFuture stuff makes that quite hard to follow and understand. I don't expect this to be the perfect example of how you build Android apps, but I would like to be able to take the crucial bits, e.g. the API interactions, and use that as a starting point for the app I'm working on.

hvisser avatar May 10 '20 14:05 hvisser

Thanks for the feedback. I've passed this along to the internal engineering group.

tjohns avatar May 13 '20 04:05 tjohns

Totally understand the Number 1 objective of this repo is to provide support to different countries to build their app in this critical timing. It is totally fine for using Java in this case. i.e. This is not a sample of Modern Android Development. This is for live saving.

But still want this to be better. Volley is good, but better if using okhttp together to support H2, best if using Retrofit + okhttp. And so not depending on Apache HTTP anymore.

seventhmoon avatar May 17 '20 01:05 seventhmoon