error-prone icon indicating copy to clipboard operation
error-prone copied to clipboard

picnic breaking `-XepDisableAllWarnings`

Open Pankraz76 opened this issue 1 month ago • 6 comments

  • https://github.com/diffplug/spotless/issues/2745
  • https://github.com/diffplug/spotless/pull/2754
  • https://github.com/diffplug/spotless/pull/2698
java.lang.UnsupportedClassVersionError: com/google/errorprone/ErrorProneJavacPlugin has been compiled by a more recent version of the Java Runtime (class file version 65.0), this version of the Java Runtime only recognizes class file versions up to 61.0

somehow picnic causing the spam and not being muted when the switch -XepDisableAllWarnings is on.

Also the bump to v.44 causing jdk compiling issue which seems strange considering patch scope.

Pankraz76 avatar Nov 21 '25 10:11 Pankraz76

somehow picnic causing the spam and not being muted when the switch -XepDisableAllWarnings is on.

From https://github.com/diffplug/spotless/issues/2745 and https://github.com/diffplug/spotless/pull/2754 it sounds like -XepDisableAllWarnings was not previously being used in that build. Are you saying that after enabling it, the picnic checks are still reporting warnings that should up in the build log?

ErrorProneJavacPlugin has been compiled by a more recent version of the Java Runtime (class file version 65.0), this version of the Java Runtime only recognizes class file versions up to 61.0

Also the bump to v.44 causing jdk compiling issue which seems strange considering patch scope.

The minimum supported JDK version to run Error Prone is JDK 21 as of Error Prone 2.43.0, see https://github.com/google/error-prone/releases/tag/v2.43.0

cushon avatar Nov 21 '25 11:11 cushon

the picnic checks are still reporting warnings that should up in the build log?

exact. They seem to sneak through. When removing picnic and the parameter i still see some MissingOverride warnings, that come from core-prone.

They are gone when the param is back on and picnic is gone.

Pankraz76 avatar Nov 21 '25 11:11 Pankraz76

Can you provide a minimal self-contained repro?

Note that picnic is an extension of Error Prone, it is a separate project: https://error-prone.picnic.tech/

cushon avatar Nov 21 '25 11:11 cushon

one way is to checkout the dedicated PR and enable picnic again to see.

b3090bd3c5dd941459eefdfc37a66d463ffcd17c

Pankraz76 avatar Nov 21 '25 11:11 Pankraz76

It isn't clear if this is a bug in Error Prone, or picnic, or a configuration issue with that specific build. If you are able to extract a minimal self-contained repro that demonstrates the problem is in Error Prone, it's more likely that the maintainers of this project will be able to help.

cushon avatar Nov 21 '25 11:11 cushon

It isn't clear if this is a bug in Error Prone, or picnic, or a configuration issue with that specific build. If you are able to extract a minimal self-contained repro that demonstrates the problem is in Error Prone, it's more likely that the maintainers of this project will be able to help.

yes, will try to provide this.

Thanks for the kind support.

The minimum supported JDK version to run Error Prone is JDK 21 as of Error Prone 2.43.0, see https://github.com/google/error-prone/releases/tag/v2.43.0

This seems to be a new challenge for gradle and spot as well. @ov7a

  • https://github.com/gradle/gradle/pull/35685
  • https://github.com/gradle/gradle/issues/35768
  • https://github.com/diffplug/spotless/issues/2755

Pankraz76 avatar Nov 21 '25 13:11 Pankraz76