error-prone icon indicating copy to clipboard operation
error-prone copied to clipboard

[rewrite] Add `Java8toJava11`

Open Pankraz76 opened this issue 4 months ago • 3 comments

related to:

  • https://github.com/diffplug/spotless/pull/2636
  • https://github.com/checkstyle/checkstyle/pull/17730
  • https://github.com/google/error-prone/issues/5195

Pankraz76 avatar Nov 08 '25 13:11 Pankraz76

yes sorry its all related to some individual recipe.

Im going to supplement and extract to make it transparent and mergeable.

Thank you.

Pankraz76 avatar Nov 10 '25 11:11 Pankraz76

Some thoughts :)

always helpful and welcome.

Let me know if something to adjust, kind regards.

Pankraz76 avatar Nov 10 '25 17:11 Pankraz76

thanks for the fixup.

rebase:

[INFO] Running recipe(s)...
[INFO] Printing available datatables to: target/rewrite/datatables/2025-11-12_13-25-51-096
[WARNING] The recipe produced 5 warning(s). Please report this to the recipe author.
[WARNING] Changes have been made to check_api/pom.xml by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.javax.AddInjectDependencies
[WARNING]             org.openrewrite.java.dependencies.AddDependency: {groupId=jakarta.inject, artifactId=jakarta.inject-api, version=1.0.3, onlyIfUsing=javax.inject.*, acceptTransitive=true}
[WARNING]         org.openrewrite.java.migrate.javax.AddCommonAnnotationsDependencies
[WARNING]             org.openrewrite.java.dependencies.AddDependency: {groupId=jakarta.annotation, artifactId=jakarta.annotation-api, version=1.3.x, onlyIfUsing=javax.annotation..*, scope=provided, acceptTransitive=true}
[WARNING] Changes have been made to check_api/src/main/java/com/google/errorprone/apply/DescriptionBasedDiff.java by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[WARNING]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[WARNING]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}
[WARNING] Changes have been made to core/pom.xml by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.javax.AddInjectDependencies
[WARNING]             org.openrewrite.java.dependencies.AddDependency: {groupId=jakarta.inject, artifactId=jakarta.inject-api, version=1.0.3, onlyIfUsing=javax.inject.*, acceptTransitive=true}
[WARNING]         org.openrewrite.java.migrate.javax.AddCommonAnnotationsDependencies
[WARNING]             org.openrewrite.java.dependencies.AddDependency: {groupId=jakarta.annotation, artifactId=jakarta.annotation-api, version=1.3.x, onlyIfUsing=javax.annotation..*, scope=provided, acceptTransitive=true}
[WARNING] Changes have been made to core/src/main/java/com/google/errorprone/bugpatterns/checkreturnvalue/ExternalCanIgnoreReturnValue.java by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[WARNING]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[WARNING]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}
[WARNING] Changes have been made to core/src/test/java/com/google/errorprone/ErrorProneJavacPluginTest.java by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[WARNING]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[WARNING]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}
[WARNING] Changes have been made to core/src/test/java/com/google/errorprone/bugpatterns/apidiff/CompilationBuilderHelpers.java by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[WARNING]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[WARNING]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}
[WARNING] Changes have been made to docgen_processor/pom.xml by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.javax.AddCommonAnnotationsDependencies
[WARNING]             org.openrewrite.java.dependencies.AddDependency: {groupId=jakarta.annotation, artifactId=jakarta.annotation-api, version=1.3.x, onlyIfUsing=javax.annotation..*, scope=provided, acceptTransitive=true}
[WARNING] Changes have been made to docgen/src/main/java/com/google/errorprone/DocGenTool.java by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[WARNING]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[WARNING]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}
[WARNING] Changes have been made to docgen/src/main/java/com/google/errorprone/BugPatternFileGenerator.java by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[WARNING]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[WARNING]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}
[WARNING] Please review and commit the results.
[WARNING] Estimate time saved: 45m
[INFO] ------------------------------------------------------------------------

Pankraz76 avatar Nov 12 '25 12:11 Pankraz76