google
FieldCanBeLocal static field incorrectly patched
Where
private static String logFileNameBase;
is only used locally, the patch replaces
Logger.logFileNameBase = Logger.logFolderName + name;
with
String Logger.logFileNameBase = Logger.logFolderName + name;
when it should be
String logFileNameBase = Logger.logFolderName + name;
I'm wondering if this is actually an incorrect patch. Shouldn't the UnnecessarilyFullyQualified check remove the Logger. prefix here if it is not required to have?
From a quick skim of the implementation it seems like only this. is being stripped.
@rickie no. Its not being "fully" qualified. Some devs want their static constants/methods qualified rather than imported directly with a static import.