eleventy-high-performance-blog
eleventy-high-performance-blog copied to clipboard
AllowDomainlist CORS in ga.js depends on deployment platform
cc @cramforce ,
My issue is very specific to Netlify deployment..
In the ga.js file, the example domain has a trailing slash
![image](https://user-images.githubusercontent.com/2099300/185801527-f78728eb-bfe4-4277-8b6b-7f1c1562ef23.png)
But unfortunately the origin returned by Netlify is bereft of the trailing slash [I'm not sure of vercel etc]
![image](https://user-images.githubusercontent.com/2099300/185801750-a3376ea8-52d4-404d-a841-c4220de1a28f.png)
leading to
![image](https://user-images.githubusercontent.com/2099300/185801947-3a1e9896-40f7-4cd5-8f72-ceb6a1e9d736.png)
Perhaps in the README and as comments in ga.js we need to draw users attention to it....its a simple but tricky bug; it takes some time to debug...or the equality comparison needs to disregard the trailing slash.
Or the example [industrail empathy needs to be shown without the trailing slash]
Yeah, the /
is wrong. Do you want to send a PR to fix it?
I will ...along a few more 😀
AC
Sent from mobile
On Sun, 21 Aug, 2022, 22:22 Malte Ubl, @.***> wrote:
Yeah, the / is wrong. Do you want to send a PR to fix it?
— Reply to this email directly, view it on GitHub https://github.com/google/eleventy-high-performance-blog/issues/147#issuecomment-1221582138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQAQZAIBZ2ZJRG5PIX7MX3V2JNDFANCNFSM57FHEDBQ . You are receiving this because you authored the thread.Message ID: @.***>