dopamine
dopamine copied to clipboard
Fix flaky test
The test testSamplePairWithUnevenProbabilities
always fails if the seed setting line is removed. A better way to test might be to check if the sampled value exists in the set of values that were put in the tree. This eliminates the dependence on seeds -- which may cause problems later.
Please let me know if this looks reasonable. I will be happy to incorporate any other suggestions that you may have. Thanks!
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Hi, I fetched and updated the branch. Can you merge into master?
hi, apologies for not getting back to you earlier.
at this point we're not taking external contributions (mostly for technical reasons). however, we're looking into changing this policy.
regarding setting the seed, i think your suggestion seems reasonable. if you don't mind, let's keep this issue open and we can come back to it once we've figured out the new policy for accepting external contributions.
thanks!