docsy icon indicating copy to clipboard operation
docsy copied to clipboard

White Cover Image Becoming Gray

Open snakers4 opened this issue 3 years ago • 9 comments

Hi,

I am trying customize Docsy by following the standard "happy-path", i.e. just clone the example project and then modify it.

I noticed that if you upload a bright (or white) hero image, it becomes gray, for example:

image

This is displayed when I have a completely white (i.e. #ffffff) hero image uploaded:

featured-background

I cannot find any information about this behaviour, can you please help, this is very frustrating, because I cannot really start making adding real content.

snakers4 avatar Mar 22 '22 09:03 snakers4

I think this behavior is to prevent the title and heading from becoming "invisible". If you want to disable this behavior, you can do one of the following options:

  • override /layouts/shortcodes/blocks/cover.html and remove the td-overlay--dark class from the section element https://github.com/google/docsy/blob/02df04c0f2d495104316ce426948069f9a98bd99/layouts/shortcodes/blocks/cover.html#L27
  • override the styles within /assets/scss/_styles_project.scss (you might create this file first)
.td-overlay--dark::after {
    background-color: transparent;
}

Hope it helps

LukeTimeWalker avatar Mar 24 '22 23:03 LukeTimeWalker

.td-overlay--dark::after {
    background-color: transparent;
}

Many thanks, this works! Is there any way to make this image not cropped or zoomed, because by default it looks a bit mushy?

snakers4 avatar Mar 25 '22 12:03 snakers4

Hi, is this issue still open? I want to work on this issue; please assign me to this.

H20220009 avatar Jan 23 '23 14:01 H20220009

@deining - FYI, the steering committee recently clarified that "we don't assign issues in this project. If you would like to contribute, please follow our guidelines." PRs are most welcome, of course. /cc @emckean

chalin avatar Feb 11 '23 13:02 chalin

@emckean @deining @chalin Can you review the changes and provide any feedback for PR #1491

H20220009 avatar Mar 29 '23 19:03 H20220009

@emckean @chalin @deining Can you please review the PR #1491 and provide feedback for the same.

H20220009 avatar Apr 11 '23 09:04 H20220009

@emckean @chalin @deining Can you please review the PR #1491 and provide feedback for the same.

H20220009 avatar Apr 14 '23 09:04 H20220009

@emckean @chalin @deining Can you please review the PR https://github.com/google/docsy/pull/1491

H20220009 avatar Apr 20 '23 07:04 H20220009

@emckean @chalin @deining Can you please review the PR https://github.com/google/docsy/pull/1491

H20220009 avatar Apr 24 '23 09:04 H20220009