docsy icon indicating copy to clipboard operation
docsy copied to clipboard

Address Language Dropdown & Search Narrow Display Issue + Farsi Font Update

Open poursalavati opened this issue 1 year ago • 2 comments

This pull request addresses two user interface issues:

Language Dropdown and Search Box in Narrow Display: Fixes the issue reported in #2035 and #1944 where the language dropdown menu (and search box) become inaccessible on narrow displays.

Farsi Font Update: Updates the Farsi font to the open-source Vazirmatn from Google Fonts. This improves compatibility and potentially resolves issues encountered with previous Vazir font implementations.

PS:
The PR has been updated to resolve an issue affecting the dark/light menu on medium and small screens. The updated code ensures consistent menu functionality across all screen dimensions:

Demo: https://deploy-preview-2057--docsydocs.netlify.app/
Multi-lingual demo: https://rdrp.ir

Before:

After:

Farsi Font correction + Dropdown menu

poursalavati avatar Jul 24 '24 19:07 poursalavati

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 24 '24 19:07 google-cla[bot]

Fixed a minor bug.

poursalavati avatar Jul 31 '24 19:07 poursalavati

HI @poursalavati, thanks for your PR. Note that Docy's RTL support has been upgraded, for details see:

  • #1442

So I'm unsure which parts of this PR are still relevant. I'm going to close this for now. Feel free to resubmit PRs -- I strongly suggest submitted separate PRs for each issue resolved. If you aren't able, I'll revisit this PR later when I have the time. Thanks!

chalin avatar Oct 17 '24 14:10 chalin