docsy icon indicating copy to clipboard operation
docsy copied to clipboard

Fixes issue with the search input box always taking the user to default language page

Open cjyabraham opened this issue 1 year ago • 2 comments

Fixes issue with the search input box always taking the user to the default language search results (https://github.com/google/docsy/issues/1558)

The problem was that the js script had no knowledge of the current language and so always redirected the user to the default language page. Here I'm passing the correct search results page in to the script from a data element on the search input box.

cjyabraham avatar Mar 24 '24 02:03 cjyabraham

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 24 '24 02:03 google-cla[bot]

Thanks for this PR @cjyabraham. FYI, this is still on the radar. I'll add it as a candidate to release 0.11.0 (#1944). Docsy 0.10.0 is just hot off the press! 🔥

chalin avatar May 01 '24 21:05 chalin