docsy icon indicating copy to clipboard operation
docsy copied to clipboard

GDPR: font-face is fetched from cdn

Open datamuc opened this issue 2 years ago • 6 comments

diff --git a/assets/scss/rtl/_main.scss b/assets/scss/rtl/_main.scss
index 6ea131e..960d5c9 100644
--- a/assets/scss/rtl/_main.scss
+++ b/assets/scss/rtl/_main.scss
@@ -30,7 +30,9 @@ body:lang(ur) {
 }
 
 body:lang(fa) {
-  @import url("https://cdn.jsdelivr.net/gh/rastikerdar/[email protected]/dist/font-face.css");
+  @if $td-enable-google-fonts {
+    @import url("https://cdn.jsdelivr.net/gh/rastikerdar/[email protected]/dist/font-face.css");
+  }
   font-family: "Vazir", "Open Sans", -apple-system, BlinkMacSystemFont,
     "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif, "Apple Color Emoji",
     "Segoe UI Emoji", "Segoe UI Symbol";

Maybe you want to do something like this, even though it's not a google font here, but the problem is not google fonts. It's external resources in general.

datamuc avatar Apr 04 '23 08:04 datamuc

There was a PR that addressed a bunch of these issues, but unfortunately didn't get merged yet: https://github.com/google/docsy/pull/1204

fekete-robert avatar Apr 04 '23 09:04 fekete-robert

Duplicate of #1204

datamuc avatar Apr 04 '23 09:04 datamuc

That particular thing is not covered by #1204

datamuc avatar Apr 06 '23 09:04 datamuc

OK, so the font data comes from a CDN. What links that to EU privacy legislation?

lmktfy avatar Dec 08 '25 08:12 lmktfy

If you load resources from a third party, this third party is able to track users. And I just don't want to deal with the implications from that.

datamuc avatar Dec 08 '25 10:12 datamuc

If you load resources from a third party, this third party is able to track users. And I just don't want to deal with the implications from that.

Please note, that assets/scss/rtl/_main.scss was removed from the repo with b3aa0c98b2cc1e4f2, so updating to the latest docsy version should cure the specific problem mentioned above. There might be other issues with resources fetched from CDN, though.

deining avatar Dec 08 '25 20:12 deining