docsy icon indicating copy to clipboard operation
docsy copied to clipboard

Published 20 hours ago • verified publisher icon google

Reintroduce RTL support using BSv5 RTLCSS

Open chalin opened this issue 2 years ago • 5 comments
trafficstars

In our move to Bootstrap v5 (BSv5), we are adopting the Bootstrap approach to RTL, as described in https://getbootstrap.com/docs/5.3/getting-started/rtl/. The good news is that we don't have to rename all properties that have logical counterparts (at least for now), since RTLCSS handles their translation appropriately.

  • [x] Drop import of custom Docsy RTL styling, which was designed for Bootstrap v4 - #1443
  • [x] #2002
    • [x] #2004
  • [x] #2020
    • [x] #2021
  • [x] #2018
    • [x] #829
    • [x] #2011
  • [x] #2025
  • [ ] #2005
  • [ ] Test it out on the Docsy example
  • [ ] #2003
  • [ ] Update the UG. Drop the dated config and refer the reader to the Docsy example

Related:

  • https://github.com/kubernetes/website/issues/45077
  • https://github.com/kubernetes/website/issues/22730

Notes:

  • Context: #470
  • Would a switch to Bootstrap's RTL solution help address the following as well: https://github.com/matrix-org/docsy/issues/1? Related(?): #605

Other:

  • https://github.com/twbs/bootstrap/blob/cf9454caa00872899215603e5e036d9a824b1b11/package.json#L46

chalin avatar Feb 25 '23 20:02 chalin

I think we may need some upstream help to support an Arabic localization for the kubernetes.io website (using Docsy as a theme).

  • https://github.com/kubernetes/website/pull/44902

And to link this issue to the Kubernetes site more generally, I think solving this issue will also go toward solving https://github.com/kubernetes/website/issues/22730

/cc @mboukhalfa, @a-mccarthy, @sftim

nate-double-u avatar Feb 06 '24 21:02 nate-double-u

All: as I mentioned in Slack, BS's RTL support is experimental:

Bootstrap's RTL feature is still experimental and will evolve based on user feedback. Spotted something or have an improvement to suggest? Open an issue, we'd love to get your insights.

chalin avatar Feb 07 '24 12:02 chalin

+1 @nate-double-u, this would help enable new languages that have started or expressed interest in localizating Kubernetes documentation.

cc: @seokho-son

a-mccarthy avatar Feb 07 '24 15:02 a-mccarthy

@a-mccarthy @seokho-son : if you (and members of your community) could upvote this issue, it would help me assess the relative importance of the feature. Thanks.

chalin avatar Apr 24 '24 18:04 chalin

+1 this important since Arabic localization is in progress and expected to be alive on k8s website but the RTL issues are blocking even the preview of the progress ! this issue will greatly help

mboukhalfa avatar Apr 27 '24 10:04 mboukhalfa