docsy
docsy copied to clipboard
feat: Expose cdn settings as params
This moves the configuration of much of the cdn (js/css) into the configuration so they can be more easily maintained.
Signed-off-by: Brad Beam [email protected]
Thanks for this! This is a potentially interesting approach (especially as we have some users who don't necessarily want to use our chosen CDNs), but is presumably going to break any site that doesn't update their config.toml/yaml
Thoughts @chalin @geriom @emckean?
Maybe we could use the default function of hugo, and use the config parameters if set, or use the original cdns if not.
I'll have a look at how the scripts partial would look if we used defaults.
Sorry for the delay, I just pushed up changes to include defaults inside the templates.
This moves the configuration of much of the cdn (js/css) into the configuration so they can be more easily maintained.
I like the idea. This PR does not pull in the latest versions of the resources, however (e.g. it pulls in KaTeX 0.15.1, while latest version is 0.16.2.) Were great if this could be improved.
I wanted to keep the scope of the change as minimal as possible. I think version bumps can be done as followups to this.