docsy icon indicating copy to clipboard operation
docsy copied to clipboard

card-code has excess margin at bottom

Open chalin opened this issue 2 years ago • 5 comments

Visit https://www.docsy.dev/docs/adding-content/shortcodes/#shortcode-card-code-for-programming-code and you'll see:

image

There's an excess 32px margin at the bottom of the C card-code example.

/cc @deining

chalin avatar Aug 12 '22 12:08 chalin

While working on this issue it might make sense to cleanup the excess generated whitespace.

chalin avatar Aug 12 '22 14:08 chalin

Screenshot 2022-08-15 230537

@chalin Is this is the desired design?

03amir avatar Aug 15 '22 17:08 03amir

Yes, if by that you've removed the "excess 32px margin at the bottom" :).

chalin avatar Aug 15 '22 17:08 chalin

yes! @chalin can I work on this issue?

03amir avatar Aug 15 '22 19:08 03amir

Sure. I'd like to give @deining some time to respond though, since this is his feature.

chalin avatar Aug 15 '22 20:08 chalin

Hello can I work on this issue?

adisagar2003 avatar Oct 12 '22 23:10 adisagar2003

Hello can I work on this issue?

Yes, go ahead, your PR is welcome. Apprecating your efforts, good luck!

deining avatar Oct 13 '22 05:10 deining

Hi, is this issue still open? If yes I would like to work on this. Can you assign it to me?

varun-khachane avatar Jan 26 '23 09:01 varun-khachane

Hi @varun-khachane: We don't assign issues in this project. If you would like to contribute please check out our Contributing Guidelines.

chalin avatar Jan 26 '23 12:01 chalin