docsy icon indicating copy to clipboard operation
docsy copied to clipboard

cards-pane and tabbed-panes style import causes style overrides of Bootstrap card and Docsy highlight styles

Open chalin opened this issue 2 years ago • 1 comments

The following PR

  • #1009

introduced an override of the Bootstrap styles for .card-deck, .card, etc. through shortcodes/cards-pane.scss. This style overrides is an undesirable breaking change.

My guess is that this problem was introduced way back via:

  • #532

but that it wasn't as obviously manifested until cards-pane.scss got processed along with all other Bootstrap styles (as is done in #1009).

The card-related style changes should only be applied in the context of Docsy cards and card-decks. @deining - do you agree?

Edit: this also happens for the .td-content .highlight Docsy style.

  • [x] Fix style overrides for:
    • [x] card-related styles - #1157
    • [x] highlight - #1163
  • [ ] Add a note to the 0.3.0 CHANGELOG entry concerning this breaking change - #1167

chalin avatar Aug 12 '22 00:08 chalin

I've generalized this issue to cover tabbed-panes styles since the same unintention style override is happening for .td-content .highlight.

chalin avatar Aug 12 '22 13:08 chalin