docsy icon indicating copy to clipboard operation
docsy copied to clipboard

Update FontAwesome 5 to FontAwesome 6

Open samiahmedsiddiqui opened this issue 3 years ago • 6 comments

samiahmedsiddiqui avatar Jul 15 '22 12:07 samiahmedsiddiqui

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 15 '22 12:07 google-cla[bot]

@LisaFC @narrenfrei @raum51

samiahmedsiddiqui avatar Jul 15 '22 12:07 samiahmedsiddiqui

@LisaFC and @raum51 could you have a look at this one? Fontawesome 6 would be very good to have by default, instead of us having to work around and add it manually. It looks like there's a Docsy release planned for fall, and we'd love to help get this into that.

polarweasel avatar Aug 06 '22 05:08 polarweasel

Will take a look - @chalin, can you take a look as well? Agree would be good to have the latest version for the next Docsy release. It doesn't look like it's likely to break anything but do FontAwesome themselves document any breaking changes? Don't want any users to suddenly end up with unexpected icons.

LisaFC avatar Aug 09 '22 18:08 LisaFC

Will take a look as soon as I can. Please rebase & resolve the conflicts, thanks.

chalin avatar Aug 09 '22 21:08 chalin

@chalin conflicts resolved.

samiahmedsiddiqui avatar Aug 10 '22 05:08 samiahmedsiddiqui

Backward compatibility information from the project: https://fontawesome.com/docs/web/setup/upgrade/whats-changed#backward-compatibility

Lots of icons got renamed, but the v5 names will still work. It'd be worth pointing to this table in the release notes, though, to make people aware that they should pick up the new names at some point.

polarweasel avatar Aug 11 '22 21:08 polarweasel

Thanks @samiahmedsiddiqui for the PR. Thanks @polarweasel for the link to the backwards compatibility page.

FYI, some prep work which I'd like reviewed and merged before this PR:

  • #1164

Comments are welcome over on that PR.

chalin avatar Aug 15 '22 09:08 chalin

I've collected the followup tasks in:

  • #1171

chalin avatar Aug 15 '22 17:08 chalin