docsy icon indicating copy to clipboard operation
docsy copied to clipboard

Apply table styling to all tables in td-content, not just direct chil…

Open NatasaKralj opened this issue 2 years ago • 3 comments

As stated in https://github.com/google/docsy/issues/883, tables were not being styled properly in <details><summary> blocks. I found the same issue to affect tables nested in list elements. Removing > from the table entry enables proper styling to be applied to any table element that's a child of td-content.

NatasaKralj avatar May 23 '22 13:05 NatasaKralj

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar May 23 '22 13:05 google-cla[bot]

@NatasaKralj it would be great to get this PR accepted as it'll really help us.

chipzoller avatar Aug 06 '22 16:08 chipzoller

@chipzoller Apologies for the late response. I am trying to sort out signing the Google CLA before updating the PR. Hopefully I will resolve this soon, otherwise I will submit another PR from my personal account.

NatasaKralj avatar Aug 10 '22 11:08 NatasaKralj

Any updates here? This PR would really help us.

chipzoller avatar Oct 03 '22 12:10 chipzoller

Hello, apologies again for the long wait time.

I created a new PR from my personal GH account (where I could freely sign the Google CLA). The new PR has > removed from additional elements, as requested by @geriom. I'm closing this one.

NatasaKralj avatar Oct 05 '22 15:10 NatasaKralj