digitalbuildings icon indicating copy to clipboard operation
digitalbuildings copied to clipboard
verified publisher icon google

Fix a bug about wrong order of function arguments

Open LostBenjamin opened this issue 3 years ago • 3 comments

Hi,

This pull request is a fix to a potential bug about wrong order of function arguments at tools/validators/instance_validator/tests/entity_instance_test.py. Please check the changes.

Best, Jingxuan

LostBenjamin avatar Jun 15 '22 16:06 LostBenjamin

@charbull ptal

tasodorff avatar Jun 29 '22 18:06 tasodorff

This is a valid bug according to https://github.com/abseil/abseil-py/blob/58ead8c22230a2493006fa0ab9f76776b6e7280f/absl/testing/absltest.py#L595. Thanks @LostBenjamin for finding this! I am going to make this change internally and sync the codebase back over to Github which means I will close this PR for now. However, the bug fix will be implemented.

trav3711 avatar Jul 07 '22 16:07 trav3711

@trav3711 is this fix complete?

tasodorff avatar Sep 20 '22 03:09 tasodorff

This fix is complete internally and externally: https://github.com/google/digitalbuildings/blob/8ac3398f64b25560e1b49840dfd1e019aebe10b3/tools/validators/instance_validator/tests/entity_instance_test.py#L83

closing.

trav3711 avatar Oct 28 '22 17:10 trav3711