create new types for taiwan project

[terryterpt]

Hi, I am terry from Primustech MSI and currently doing the DBO for the new Google project in Taiwan.

I am creating this pull request to add entity and abstract types for this project.

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[cstirdivant]

@terryterpt I am pausing my review until you address a few things across this PR:

• Address the validator error
• Remove all references to a specific building code
• All AHU types must have some ECON type
• Discourage the use of individual fields on canonical types, please review to ensure you can model as many fields within an abstract type instead
• Add guids to all new abstract and canonical types

[terryterpt]

@cstirdivant , I have rectify the following items, please help to review my commit again.

1. Address the validator error
2. Remove all references to a specific building code
3. All AHU types must have some ECON type
4. Discourage the use of individual fields on canonical types, please review to ensure you can model as many fields within an abstract type instead
5. Add guids to all new abstract and canonical types

[cstirdivant]

Terry,

The PR name and description still has the building specific name, please remove.

In general, this PR is not acceptable.

• Please make sure you only have yaml files in your PR. The proper validation checks won't run if you have python files in your PR.
• The AHU types are messy, refrain from defining individual fields on the canonical types (try to use only abstract types or extend existing ones to meet your needs)
• AHU types should have some heating/cooling temperature control (you define CHW/HW valve control and temperature control separately, but I am assuming they are actually interconnected -- ie the valve controls to a temperature setpoint).

[terryterpt]

Hi @cstirdivant ,

I have done the following:

• I have extended the general type AHU & DOAS with opt-use fields, so there is on longer any individual fields.
• I have updated the AHU types with the valve controls linked to the temperature setpoint.

[terryterpt]

Hi @cstirdivant , please help to review my commit again.

[terryterpt]

Hi @shambergoldstein,

I have the CH type CH_SS_CC2XM_REFSM2X_REFPM2X with the setpoint that is indeed hidden in the BMS system. Secondly, the CHWS_RWTM is indeed just a temperature sensor on it own with no setpoint

[terryterpt]

@shambergoldstein , I have removed the files that are not Yaml