diff-match-patch icon indicating copy to clipboard operation
diff-match-patch copied to clipboard

Typescript (.ts) port of the file diff_match_patch_uncompressed.js

Open ramin-zaghi opened this issue 3 years ago • 4 comments

This is useful for projects that use Typescript (e.g. a Visual Studio Code Extension). Tested using the same logic as is present in the Patch Demo. "visualSilicon" has also submitted a CLA for contributions to Google open-source projects.

ramin-zaghi avatar Sep 14 '22 23:09 ramin-zaghi

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 14 '22 23:09 google-cla[bot]

@NeilFraser would you review and merge this please? or do you no longer accept changes to this project?

ramin-zaghi avatar Sep 15 '22 00:09 ramin-zaghi

All JavaScript is Typescript, but not the other way around. Seems better to just keep the JS version so there's less maintenance porting between two essentially identical implementations.

Azmisov avatar Dec 17 '22 02:12 Azmisov

All JavaScript is Typescript, but not the other way around. Seems better to just keep the JS version so there's less maintenance porting between two essentially identical implementations.

Since Typescript is compiled into Javascript, you would still only need to maintain one - the Typescript version. Anyways, even if Typescript were a strict no-go, could we at least get some docstrings?

nicolello-dev avatar Mar 19 '24 17:03 nicolello-dev