google
Switch use from `JacksonFactory` to `GsonFactory`.
This is mirroring a global change we're making in the monorepo to reduce concerns from security.
Gradle is strangely reporting a seemingly-unrelated Guava error when I build with these changes:
> Task :portability-transfer:compileJava FAILED
/usr/local/google/home/nherring/github/data-transfer-project/portability-transfer/src/main/java/org/datatransferproject/transfer/WorkerModule.java:18: error: cannot find symbol
import static com.google.common.collect.MoreCollectors.onlyElement;
^
symbol: class MoreCollectors
location: package com.google.common.collect
/usr/local/google/home/nherring/github/data-transfer-project/portability-transfer/src/main/java/org/datatransferproject/transfer/WorkerModule.java:18: error: static import only from classes and interfaces
import static com.google.common.collect.MoreCollectors.onlyElement;
^
2 errors
I cannot tell if my depends are perturbing something in the Guava version resolution machine.
Gradle is strangely reporting a seemingly-unrelated Guava error when I build with these changes:
Huh that's indeed confusing given your PR. What gradle task you running exactly? (or perhaps just share your whole commandline?)
And the demo-server build.gradle blanket overrides the guava version for all artifacts, which doesn't work for the versioning scheme for listenablefuture or failureaccess.
Ugh. git rebase -i is not my friend. I redid the edits three different times and still managed to drop them on the floor. :(
Adding Will and Jonathon for one final review from maintainers before submitting.
Will if you have no concerns, feel free to merge after your review
Is this waiting on an affirmative review by @jzacsh and/or @wmorland, or was that advisory only? In the latter case, how long until it's worth merging and dealing with potential aftermath of a late review (if any) later?