ctfscoreboard icon indicating copy to clipboard operation
ctfscoreboard copied to clipboard

Dependency updates

Open wjwoodson opened this issue 3 years ago • 2 comments

This PR includes ~two~ three updates to resolve issues recently encountered when setting up a new debian:buster-image based installation:

  1. Latest Flask library is no longer compatible with Werkzeug<1.0.0 (at least since Flask 2.0.0). The changes here remove the Werkzeug version pin from requirements, and make a small update to use cachelib for functionality extracted to its own library (ref).
  2. Small change to migrate jinja2.Markup() usage to markupsafe.Markup() for similar library deprecations (ref).
  3. Updates the MySQL connection string in README to specify using the pymysql driver included in the requirements file (ref).

wjwoodson avatar Jun 04 '22 15:06 wjwoodson

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 04 '22 15:06 google-cla[bot]

It's also required to update send in scoreboard/attachments/file.py as due to download_name replacing Flask's attachment_filename: https://github.com/pallets/werkzeug/blob/d36aaf12b5d12634844e4c7f5dab4a8282688e12/src/werkzeug/utils.py#L400

gwarf avatar Oct 07 '22 10:10 gwarf