cpu_features icon indicating copy to clipboard operation
cpu_features copied to clipboard

Published 20 hours ago • verified publisher icon google

S390X Support

Open marquitos0119 opened this issue 2 years ago • 3 comments

This PR adds support for cpu_features on S390X architectures including the latest z16 hwcapabilities.

marquitos0119 avatar Sep 19 '22 15:09 marquitos0119

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 19 '22 15:09 google-cla[bot]

z15 Model T01 would be 8561 and not 3932 you might also want some older processors as well

2964 and 2965 z13
3906 and 3907 z14

borntraeger avatar Sep 20 '22 15:09 borntraeger

Thanks for the review. I ended up removing the explicit model checking, since the elf AT_PLATFORM definition includes this.

marquitos0119 avatar Sep 20 '22 15:09 marquitos0119

Thanks, I've made those changes

marquitos0119 avatar Oct 25 '22 15:10 marquitos0119

Thanks, I've made those changes

Thx, can you also turn the num_processors field into an int? then I think it's good to go.

gchatelet avatar Oct 26 '22 07:10 gchatelet

Made a rookie mistake, forgot to set my git user+email on a new environment and it failed the CLA check. I amended and I think its good to go now

marquitos0119 avatar Oct 26 '22 16:10 marquitos0119