cpu_features icon indicating copy to clipboard operation
cpu_features copied to clipboard

Add RISC-V support

Open DaniAffCH opened this issue 3 years ago • 2 comments

I added RISC-V architecture support on linux by parsing /proc/cpuinfo. It has been tested using QEMU emulator. I have done the following points:

  • features detection (i kept it as a single letter, is it fine or do i have to replace it with its description?)
  • microarchitecture detection (i'm not sure if it's correct, so check it carefully)
  • vendor detection Tests have been added as well

DaniAffCH avatar Aug 30 '22 11:08 DaniAffCH

Ok @michael-roe, Do I have to support these extensions as well?

DaniAffCH avatar Aug 31 '22 19:08 DaniAffCH

Ok @michael-roe, Do I have to support these extensions as well?

Probably ought to support all the user space ones. The supervisor state ones (starting with S) are less relevant to user space programs that call cpu_features, so can probably leave those out.

michael-roe avatar Aug 31 '22 19:08 michael-roe

Hi @DaniAffCH are you still interested in contributing to this branch? I can take it over if you want.

gchatelet avatar Nov 09 '22 13:11 gchatelet

Hi @gchatelet, yes I'm still interested in contributing to this project but I have a really busy period, so I'm unable to fix the PR issues, I'll do it as soon as I'm free though. If you want to keep the PR list clean feel free to close my PR and I'll open it again when I'm ready.

DaniAffCH avatar Nov 10 '22 09:11 DaniAffCH

Hi @gchatelet, yes I'm still interested in contributing to this project but I have a really busy period, so I'm unable to fix the PR issues, I'll do it as soon as I'm free though. If you want to keep the PR list clean feel free to close my PR and I'll open it again when I'm ready.

Ok no worries. I've started #287 based on this PR to retain your original work (I hope you don't mind!). I'm now working on fixing the comments we've made. Thx to @Mizux we also have a running CI for RISC-V 💪.

gchatelet avatar Nov 10 '22 10:11 gchatelet

Hi @gchatelet, yes I'm still interested in contributing to this project but I have a really busy period, so I'm unable to fix the PR issues, I'll do it as soon as I'm free though. If you want to keep the PR list clean feel free to close my PR and I'll open it again when I'm ready.

Ok no worries. I've started #287 based on this PR to retain your original work (I hope you don't mind!). I'm now working on fixing the comments we've made. Thx to @Mizux we also have a running CI for RISC-V muscle.

Ok, good job! I can probably be back active in 2 weeks. Please keep track of the problems you have fixed (or I'm gonna figure it out from your commits).

DaniAffCH avatar Nov 10 '22 11:11 DaniAffCH

Merged as part of #287 . Thx a lot @DaniAffCH for the initial implementation and research, this helped !

gchatelet avatar Jan 13 '23 10:01 gchatelet