containerregistry icon indicating copy to clipboard operation
containerregistry copied to clipboard

Probe naked domain and protocols for credential

Open BrentDouglas opened this issue 6 years ago • 3 comments

When probing for a registries credential currently only the https prefixed domain is searched. Some credential services (e.g. docker-credential-secretservice) do not store the protocol and only return the credential for the naked domain. This probes the naked domain, https and http prefixed domain to see if any are stored and returns the first match.

BrentDouglas avatar Oct 31 '18 05:10 BrentDouglas

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Oct 31 '18 05:10 googlebot

I signed it!

BrentDouglas avatar Oct 31 '18 05:10 BrentDouglas

CLAs look good, thanks!

googlebot avatar Oct 31 '18 05:10 googlebot