comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

Simplify the solution to prefix matching

Open zhouwfang opened this issue 2 years ago • 3 comments

zhouwfang avatar Jan 03 '23 06:01 zhouwfang

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 03 '23 06:01 google-cla[bot]

Hi @zhouwfang, thanks a lot! This looks much better indeed :smile:

I would be happy to merge this, we just need the CLA to be signed.

mgeisler avatar Jan 03 '23 15:01 mgeisler

Hi @mgeisler, It should be all set now. Thanks.

zhouwfang avatar Jan 04 '23 04:01 zhouwfang

Thanks! Could I also get you to add a few comments to explain the solution? In particular the trick with turning the elements into Option so we can detect when the prefix iterator ends.

mgeisler avatar Jan 04 '23 08:01 mgeisler