clusterfuzz icon indicating copy to clipboard operation
clusterfuzz copied to clipboard

Update appengine imports for external_testcase_reader.

Open pgrace-google opened this issue 10 months ago • 4 comments

(drive by add additional component filter in query for extra safety)

pgrace-google avatar Feb 27 '25 17:02 pgrace-google

(context failure logs: http://shortn/_BBefaIUwXU)

pgrace-google avatar Feb 27 '25 18:02 pgrace-google

updated!

i do not actually know if the problem of the imports is to be fixed by adding that to the path - but does that seem like a sensible solution to you??

pgrace-google avatar Feb 28 '25 21:02 pgrace-google

updated!

i do not actually know if the problem of the imports is to be fixed by adding that to the path - but does that seem like a sensible solution to you??

So the issue is coming from these two imports:

from appengine.libs import form
from appengine.libs import gcs

Looking at the other cron jobs in the same directory, I noticed non of them use appengine imports.

Also, I noticed that for cron jobs like cleanup (https://github.com/google/clusterfuzz/blob/8e43b8b4bc7b984defe62654a2ec05365a7fdb7f/src/clusterfuzz/_internal/cron/cleanup.py#L4), there's an appengine cron handler called cleanup located here: https://github.com/google/clusterfuzz/blob/8e43b8b4bc7b984defe62654a2ec05365a7fdb7f/src/appengine/handlers/cron/cleanup.py#L4 Same pattern exists for predator_pull and triage in https://github.com/google/clusterfuzz/tree/8e43b8b4bc7b984defe62654a2ec05365a7fdb7f/src/appengine/handlers/cron.

The right approach might be similar to what was done for these three cron jobs.

Adding @jonathanmetzman as the code owner.

alhijazi avatar Mar 03 '25 20:03 alhijazi

This pull request has not had any activity for 60 days and will be automatically closed in two weeks

github-actions[bot] avatar Jun 13 '25 20:06 github-actions[bot]

Automatically closing stale pull request

github-actions[bot] avatar Jun 27 '25 21:06 github-actions[bot]