google
use request host value instead of auth domain when proxying
This modifies how the target URL for proxying auth requests is instantiated, instead of using auth.auth_domain, it uses request.host which achieves the same behavior, but is more robust in the sense that it'd allow setups that are behind some kind of beyond corp/zero trust proxy more easily.
@jonathanmetzman : sure thing.
Imagine a set up where clusterfuzz is behind a virtualhost proxy, the front domain is front-server.com, and the back domain is back-server.com.
The main blocker here is that for the oauth proxy to work, auth.auth_domain() needs to return front-server.com so that the oauth redirect URI works correctly. But, in this setup, the value of request.url is https://back-server.com/__/auth/path, and so request.url.replace("front-server.com", auth.real_auth_domain(), 1) does nothing.
All the code is trying to do here is replace the host value in the URL https://back-server.com/__/auth/path with the value returned from auth.real_auth_domain(), which we can achieve with the change proposed in this PR.
@jonathanmetzman I can't view the reason why the clusterfuzz-testing-public job is failing, could you take a look?
