clusterfuzz icon indicating copy to clipboard operation
clusterfuzz copied to clipboard

Consider adding linting as a git hook before pushing

Open jonathanmetzman opened this issue 6 years ago • 3 comments

Having linting as a git hook before pushing will prevent submission of broken PRs for review. The downside is it will slow down pushing in the common case (user has linted themselves and fixed errors) and it will require a little bit of work in butler.py to get the git hooks working without user intervention.

@oliverchang @inferno-chromium @Dor1s @mbarbella-chromium What do you think?

jonathanmetzman avatar Apr 23 '19 12:04 jonathanmetzman

+1 to have it

Dor1s avatar Apr 23 '19 13:04 Dor1s

SGTM, feel free to add this.

inferno-chromium avatar Apr 23 '19 14:04 inferno-chromium

also +1

oliverchang avatar Apr 23 '19 21:04 oliverchang