clusterfuzz icon indicating copy to clipboard operation
clusterfuzz copied to clipboard

Remove migrated cron jobs from AppEngine, k8s jobs fix and tf examples

Open andrei-near opened this issue 10 months ago • 2 comments

  • Removing cron jobs migrated to k8s workloads.
  • Adding missing REDIS_HOST in k8s workflows yaml definitions. Without this, envsubst will not work and workload jobs will fail.
  • Adding Terraform main.tf example along with resource import command

andrei-near avatar Apr 22 '24 09:04 andrei-near

  • Removing cron jobs migrated to k8s workloads.
  • Adding missing REDIS_HOST in k8s workflows yaml definitions. Without this, envsubst will not work .
  • Adding Terraform main.tf example along with resource import command

Is there a way we can pass REDIS_HOST to every job without explicitly doing so in each config file? I don't love the repetition for a feature we don't need.

jonathanmetzman avatar Apr 22 '24 14:04 jonathanmetzman

  • Removing cron jobs migrated to k8s workloads.
  • Adding missing REDIS_HOST in k8s workflows yaml definitions. Without this, envsubst will not work .
  • Adding Terraform main.tf example along with resource import command

Is there a way we can pass REDIS_HOST to every job without explicitly doing so in each config file? I don't love the repetition for a feature we don't need.

An option would be changes in this code but this however will not make it very obvious the k8s workloads are using Redis. I'd prefer to have it explicit in yaml than having to dig through code to find out how it is provisioned. This PR is rather a fix for current situation when workloads will fail initialisation if REDIS_HOST env is missing but also some examples about new terraform configs required by default.

P.S re-read the comment: redis is used by default in k8s workloads. I'm missing context about why it was required in first place but in current form, it's non-functional and will block new deployments

andrei-near avatar Apr 22 '24 15:04 andrei-near