clusterfuzz icon indicating copy to clipboard operation
clusterfuzz copied to clipboard

Update Android code links

Open TheCoryBarker opened this issue 2 years ago • 5 comments

URL change after CS migration

TheCoryBarker avatar Aug 17 '23 20:08 TheCoryBarker

This looks good, assuming that drc can be used in all places that rcl could have been used (for non-Android).

Can you please update the tests here too? Should be a simple fix.

oliverchang avatar Aug 17 '23 22:08 oliverchang

I dont think this is interchangeable, this is dealing with code searches update to deprecate packages that should affect everyone (Chrome included). Is Chrome still able to use the legacy code search packages? The new link in Chrome should look something like this:

https://source.corp.google.com/h/chrome-internal/codesearch/chrome/src/+/main:<package>/<path>/<file>;l=1;bpv=1;bpt=0;drc=<commit>

it's a change to the sourcemaps file too. Here is my change to the sourcemaps file: http://critique/557948970

TheCoryBarker avatar Aug 17 '23 22:08 TheCoryBarker

Looks like there is a redirect in code search right now but it just isn't correct for Android. Maybe I'll just update the redirect to fix our link problems instead of updating the links we are providing. What do you think? This way other teams don't have to make these same updates.

TheCoryBarker avatar Aug 17 '23 22:08 TheCoryBarker

Do you want to fix the tests so we can land this?

jonathanmetzman avatar Aug 22 '23 17:08 jonathanmetzman

ping

jonathanmetzman avatar Aug 05 '24 19:08 jonathanmetzman