clusterfuzz icon indicating copy to clipboard operation
clusterfuzz copied to clipboard

Replace download_as_string with download_as_bytes

Open jonathanmetzman opened this issue 2 years ago • 6 comments

download_as_string is deprecated.

jonathanmetzman avatar Jul 27 '23 13:07 jonathanmetzman

Hi @jonathanmetzman, there was only one case and it's now replaced. 🙏🏻

MjMoshiri avatar Aug 17 '23 20:08 MjMoshiri

Thanks for pointing this out!

jonathanmetzman avatar Aug 18 '23 15:08 jonathanmetzman

Actually looks like it's still here https://github.com/google/clusterfuzz/blob/c2de16f9c9ae209a56156f69431e0bc48e608969/src/clusterfuzz/_internal/google_cloud_utils/storage.py#L289

jonathanmetzman avatar Aug 18 '23 15:08 jonathanmetzman

Hello again @jonathanmetzman, pull request above changes that line but it's not approved yet.

MjMoshiri avatar Aug 18 '23 15:08 MjMoshiri

Sorry I am new to ClusterFuzz and trying to introduce it to my team. Does this issue mean that if I deployed a ClusterFuzz production setup with version 2.6.0 tag recently, reading files from Google Cloud Storage will not work?

I just deployed the ClusterFuzz to App Engine and can access to the .appspot.com, also built and uploaded OpenSSL fuzzer target to ClusterFuzz and the bot running on the GCP did show the string "fuzz libFuzzer libfuzzer_asan_linux_openssl". However, the ClusterFuzz homepage (ie: the Testcases page) did not show the testcase titled “Heap-buffer-overflow READ{*}” as expected. Seems like it did not fuzz the target I uploaded.

cdxvy30 avatar Aug 23 '23 03:08 cdxvy30

This issue does not mean that. I'd look at the logs in google cloud to see why it's failed to produce crashes.

jonathanmetzman avatar May 02 '24 19:05 jonathanmetzman