clusterfuzz icon indicating copy to clipboard operation
clusterfuzz copied to clipboard

tsan_suppressions.txt not in repository

Open mi-ac opened this issue 3 years ago • 1 comments

Test cases like https://clusterfuzz.com/testcase-detail/6560743240695808 use TSAN_OPTIONS and refer to a tsan_suppressions.txt file at: /mnt/scratch0/clusterfuzz/src/appengine/config/suppressions/tsan_suppressions.txt

There appears to be no such file in https://github.com/google/clusterfuzz/tree/master/src/appengine

We'd like to either change the file and include a suppression for V8 from https://source.chromium.org/chromium/chromium/src/+/main:v8/tools/sanitizers/tsan_suppressions.txt - or find a way to use the latter directly. E.g. by using an environment variable.

It seems that https://github.com/google/clusterfuzz/blob/4e1f65d3579cd835fd3bf6758d852f7780997a20/src/clusterfuzz/_internal/system/environment.py#L389 offers a CONFIG_DIR_OVERRIDE. If we specify a value at the job level, how can we make it point to the absolute APP_DIR ? If that was possible, we'd bundle a folder config/suppressions/ together with V8.

V8 side issue: https://crbug.com/1401380

mi-ac avatar Dec 16 '22 09:12 mi-ac

It will be very difficult to use CONFIG_DIR_OVERRIDE just for the purpose of overriding suppressions -- there's a lot of settings expected in this, and it's not the intended use case. It's intended to encode the entire ClusterFuzz setup for a particular deployment.

Instead, would it be feasible at all to do something like https://source.chromium.org/chromium/chromium/src/+/main:build/sanitizers/tsan_suppressions.cc, and control this at a build level?

oliverchang avatar Dec 19 '22 01:12 oliverchang