clusterfuzz icon indicating copy to clipboard operation
clusterfuzz copied to clipboard

change from testcase_id to existing_testcase_id

Open lipeng28 opened this issue 3 years ago • 11 comments

Based on @inferno-chromium's confirmation, submit this PR

lipeng28 avatar Jun 02 '21 22:06 lipeng28

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jun 02 '21 22:06 google-cla[bot]

I signed it! and we'll verify it.

On Wed, Jun 2, 2021 at 3:37 PM google-cla[bot] @.***> wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA Individual signers

Corporate signers

ℹ️ Googlers: Go here https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogle%2Fclusterfuzz%2Fpull%2F2355 for more info.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/clusterfuzz/pull/2355#issuecomment-853427470, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ2NRG6MXSPQ6OXLD3ZSQDTQ2XBPANCNFSM457TIXBQ .

lipeng28 avatar Jun 03 '21 04:06 lipeng28

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jun 03 '21 04:06 google-cla[bot]

/gcbrun

oliverchang avatar Jun 03 '21 05:06 oliverchang

Can you please fix the formatting/lint error here: https://github.com/google/clusterfuzz/pull/2355/checks?check_run_id=2734259944#step:5:1593 ?

oliverchang avatar Jun 04 '21 02:06 oliverchang

Can you please fix the formatting/lint error here: https://github.com/google/clusterfuzz/pull/2355/checks?check_run_id=2734259944#step:5:1593 ? Hi, I have no idea why this kind of formatting error occurs: elif (not existing_testcase.bug_information and | not testcase.one_time_crasher_flag): | metadata = data_types.TestcaseUploadMetadata.query( | - data_types.TestcaseUploadMetadata.testcase_id == existing_testcase_id).get() | + data_types.TestcaseUploadMetadata.testcase_id == | + existing_testcase_id).get() | if metadata: | metadata.status = 'Duplicate' | metadata.duplicate_of = testcase_id | Return code is non-zero (1). Linting failed, see errors above. Error: Process completed with exit code 1.

Can you please advise?

lipeng28 avatar Jun 29 '21 00:06 lipeng28

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jun 29 '21 06:06 google-cla[bot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jun 29 '21 07:06 google-cla[bot]

I fixed the formatting issue. Could you please fix the CLA issue in https://github.com/google/clusterfuzz/pull/2355#issuecomment-870315259 ?

oliverchang avatar Jun 29 '21 07:06 oliverchang

@googlebot I fixed it.

lipeng28 avatar Jun 29 '21 14:06 lipeng28

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jun 29 '21 14:06 google-cla[bot]