clusterfuzz icon indicating copy to clipboard operation
clusterfuzz copied to clipboard

The potential issue in data_handler.py

Open lipeng28 opened this issue 3 years ago • 2 comments

Hi There

I read the code in data_handler.py, and found the following potential issue, can you please confirm?

https://github.com/google/clusterfuzz/blob/master/src/python/datastore/data_handler.py#L639 metadata = data_types.TestcaseUploadMetadata.query(
data_types.TestcaseUploadMetadata.testcase_id == testcase_id).get()

The query "data_types.TestcaseUploadMetadata.testcase_id == testcase_id" should be "data_types.TestcaseUploadMetadata.testcase_id == existing_testcase_id"

Thanks Peng

lipeng28 avatar Jun 02 '21 19:06 lipeng28

Thanks @lipeng28 , can you submit a PR patch for this.

inferno-chromium avatar Jun 02 '21 19:06 inferno-chromium

@inferno-chromium , please review this PR: https://github.com/google/clusterfuzz/pull/2355

lipeng28 avatar Jun 02 '21 22:06 lipeng28