closure-library icon indicating copy to clipboard operation
closure-library copied to clipboard

deprecation warning for Closure Library's ButtonSet

Open jmarantz opened this issue 8 years ago • 1 comments

When I compile my application I see:

/Users/jmarantz/dev/closure-library/closure/goog/ui/dialog.js:705: WARNING - Class goog.ui.Dialog.ButtonSet has been deprecated: This type is misleading: use ES6 Map instead. this.buttons_ = new goog.ui.Dialog.ButtonSet(this.getDomHelper()); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/Users/jmarantz/dev/closure-library/closure/goog/ui/prompt.js:89: WARNING - Class goog.ui.Dialog.ButtonSet has been deprecated: This type is misleading: use ES6 Map instead. var buttonSet = new goog.ui.Dialog.ButtonSet(opt_domHelper); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Is there a way to get full error reporting for my own issues, but suppress warnings within closure library? Alternatively, will this be fixed soon?

I want my builds to be warning-clean. I can kind of resolve this with grep -v but it's ugly because to be surgical for this error I need a version of grep -v that's stateful across multiple lines.

jmarantz avatar Nov 28 '17 13:11 jmarantz

Oh no, ButtonSet is going away!?

On Tue, Nov 28, 2017 at 11:29 AM, Joshua Marantz [email protected] wrote:

When I compile my application I see:

/Users/jmarantz/dev/closure-library/closure/goog/ui/dialog.js:705: WARNING - Class goog.ui.Dialog.ButtonSet has been deprecated: This type is misleading: use ES6 Map instead. this.buttons_ = new goog.ui.Dialog.ButtonSet(this.getDomHelper()); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/Users/jmarantz/dev/closure-library/closure/goog/ui/prompt.js:89: WARNING

  • Class goog.ui.Dialog.ButtonSet has been deprecated: This type is misleading: use ES6 Map instead. var buttonSet = new goog.ui.Dialog.ButtonSet(opt_domHelper); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Is there a way to get full error reporting for my own issues, but suppress warnings within closure library? Alternatively, will this be fixed soon?

I want my builds to be warning-clean. I can kind of resolve this with grep -v but it's ugly because to be surgical for this error I need a version of grep -v that's stateful across multiple lines.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/closure-library/issues/855, or mute the thread https://github.com/notifications/unsubscribe-auth/AAo2m9doOj2WiNmnrmNJVY_kzDotaSCsks5s7Aq3gaJpZM4QtPJQ .

-- André Tannús | Epungo | +55 11 2389-4360 We are a layer

atannus avatar Nov 28 '17 13:11 atannus