closure-compiler icon indicating copy to clipboard operation
closure-compiler copied to clipboard

Publish closure compiler to registry.bazel.build

Open christianscott opened this issue 10 months ago • 5 comments

Hello, I'd love to be able to depend on closure compiler via bzlmod. I believe the only blocker preventing this module being published to bcr is the use of git_override() to depend on google_bazel_common. If google_bazel_common is on the bcr then we can remove the override and also publish closure compiler. I have opened an issue in that repo as well: https://github.com/google/bazel-common/issues/213

christianscott avatar Feb 25 '25 07:02 christianscott

Would you be able to send us a pull request with the change you're asking for?

We have no knowledge of registry.bazel.build. If supporting it is as simple as a one-line change to one of our bazel build files, we're probably ok with doing that.

When creating the pull request, bear in mind that we don't actually know anything about this, and add comments appropriately.

brad4d avatar Feb 25 '25 23:02 brad4d

hey Brad, certainly. I'll work on it once google/bazel-common has been published to the registry. I'm not totally sure what is involved in publishing, but I believe that we won't need to make any changes to this repo beyond removing the git_override(). To get it published to the registry itself, IIUC I'll just need to open a PR in https://github.com/bazelbuild/bazel-central-registry

christianscott avatar Feb 26 '25 00:02 christianscott

Created PR #4226 to replace git_override

jzhan-canva avatar Mar 14 '25 02:03 jzhan-canva

git_override has been removed from codebase, next step is to publish closure compiler to registry. I think this requires the repo owner to submit request?

jzhan-canva avatar Mar 15 '25 12:03 jzhan-canva

@jzhan-canva, I'm sorry to say that I don't know how to submit the request you're talking about.

brad4d avatar Mar 19 '25 00:03 brad4d