closure-compiler icon indicating copy to clipboard operation
closure-compiler copied to clipboard

Repo links for Maven shows 404

Open elvisef opened this issue 3 years ago • 7 comments

2020-12-10_16-56 I've just typed: bazelisk build //:compiler_unshaded_deploy.jar and all this bad magic happened... ..but it is still compilng, but is it "ok" if there are 404's ?

Unfortunately an error appeared and compilation failed. 2020-12-10_17-00

What to do now ? How to fix it ? How to compile successfully ?

elvisef avatar Dec 10 '20 15:12 elvisef

I've just successfully run

cd $my_closure_compiler_git_repo
git checkout master
git pull --ff-only
bazelisk build //:compiler_unshaded_deploy.jar`

I didn't see these 404 errors.

I'm wondering if maybe the problem only occurs for folks without access to Google's internal network. Maybe we accidentally used internal-google-specific paths to the maven repo or something?

@ChadKillingsworth (or any other non-Googler really), can you reproduce this problem, or else confirm that you can build successfully?

Thanks.

brad4d avatar Dec 10 '20 20:12 brad4d

Hang on a tick, I must be wrong about us configuring things to only work within Google. The GitHub actions that we have run all the time to make sure the project isn't broken are running in GitHub, which is outside Google.

So, @elvisef I suspect this may be something specific to your setup or network.

brad4d avatar Dec 10 '20 20:12 brad4d

Hang on a tick, I must be wrong about us configuring things to only work within Google. The GitHub actions that we have run all the time to make sure the project isn't broken are running in GitHub, which is outside Google.

So, @elvisef I suspect this may be something specific to your setup or network.

Alright, I tried to recompile but no success. What I did is to append "verbose_failures" switch and that's what I got.

2020-12-11_08-17

What could be a problem here, can You help me with that ?

elvisef avatar Dec 11 '20 07:12 elvisef

Have you installed a JDK on your machine? See https://github.com/bazelbuild/bazel/issues/7304, which looks like a similar issue.

tjgq avatar Dec 11 '20 07:12 tjgq

Have you installed a JDK on your machine? See bazelbuild/bazel#7304, which looks like a similar issue.

As far as I remember a minimal java runtime packet (this one https://packages.debian.org/stretch/openjdk-8-jdk-headless) was instlaled successfully. I will check this and the thread You mentioned and I'll be back.

But indeed, I have a Debian Stretch as well (as the thread from the link).

elvisef avatar Dec 12 '20 14:12 elvisef

I also received some 404s when building the compiler, but that wasn't an issue for me as the resulting jar was working as intended. @elvisef I suspect that bazel can't detect your java installation. You could try building the compiler like that: bazel build \\:compiler_unshaded_deploy.jar --javabase=@bazel_tools\\tools\jdk:remote_jdk

VuQuangPhuc avatar Dec 15 '20 21:12 VuQuangPhuc

Still no success. JDK was downloaded and hopefully prepared but still there is an error: putty_2021-04-29_10-53-17

elvisef avatar Apr 29 '21 08:04 elvisef