clasp icon indicating copy to clipboard operation
clasp copied to clipboard

Incorrect instructions when running clasp logs --setup

Open leeyspaul opened this issue 4 years ago • 2 comments

(Note: Non-breaking issues are likely not to be prioritized. Please consider a PR in addition to your issue)

Expected Behavior

When running clasp logs --setup I'd expect including project-id into the input to be correct.

$ clasp logs --setup
Open this link: 
<scriptUrl>

Go to *Resource > Cloud Platform Project...* and copy your projectId
(including "project-id-")

? What is your GCP projectId? project-id-my-app

Actual Behavior

$ clasp logs --setup
Open this link: 
<scriptUrl>

Go to *Resource > Cloud Platform Project...* and copy your projectId
(including "project-id-")

? What is your GCP projectId? project-id-my-app

The projectId "project-id-my-app" looks incorrect.
Did you provide the correct projectID?

Line: https://github.com/google/clasp/blob/master/src/messages.ts#L128

Steps to Reproduce the Problem

  1. Run clasp logs --setup and input the "project-id"

Specifications

  • Node version (node -v): v10.10.0
  • Version (clasp -v): 2.3.0
  • OS (Mac/Linux/Windows): Mac

leeyspaul avatar Aug 15 '20 19:08 leeyspaul

Is this strictly a documentation issue? Can anyone volunteer for a PR?

PopGoesTheWza avatar Mar 19 '21 21:03 PopGoesTheWza

Is clasp expecting the project-id or the project number? The Scripts editor allows us to set the underlying GCP project via the project number, but this prompt is asking for the project-id. I'm happy to take this PR (as well as #813 ) if someone can help me understand the intended functionality

noahmercado avatar Feb 02 '22 18:02 noahmercado