ci_edit
ci_edit copied to clipboard
google
Bug: bookmarks may sometimes seem to be larger than they really are
If your cursor is at the beginning of a line (say line 4) and you perform SHIFT_UP to select previous lines, the created bookmark will include line 4. This means that you can remove the bookmark if your cursor is on line 4. I don't know if this should be a bug or a feature, but it may cause some confusion since there is no visual display that shows that this line is part of the bookmark.
I think it makes more sense if this is a bug? What are your thoughts?
It seems like this happens in GUI editors iff the cursor is on the first column. So on the first column it seems like a feature.
If the cursor is not on the first column, the bookmark is not removed (in a GUI editor). So for that case it seem like a bug.
IIUC, the trick is to determine: Is the cursor anywhere within or touching the edge of an existing bookmark. i.e. in the first column it's "touching" the edge of the selection.
We could also just say that the cursor was technically on that line, so our implementation just thinks that that line is part of the bookmark. The only issue we have to deal with is the confusion of the boundaries. However, I think if we had a visual indicator, like some icon or color next to the line number, that would resolve all the confusions.