ci_edit icon indicating copy to clipboard operation
ci_edit copied to clipboard
verified publisher icon google

Change bookmarks implementation symmetric with history

Open aaxu opened this issue 8 years ago • 3 comments

I was going to move this sometime to be imported and saved at the same time as history so it supports multiple views, but wanted to check if it works properly. Is bookmarks a functional feature right now?

aaxu avatar Aug 23 '17 00:08 aaxu

Last I checked bookmarks functioned, but the experience using them is poor.

I was hoping to make F2 goto next bookmark, shift+F2 goto prior bookmark, ctrl+F2 to set bookmark, and alt+F2 to clear bookmark. I haven't worked out how to make ctrl+F2 and alt+F2 work reliably. So that left bookmarks in a less than ideal place. e.g. to set a bookmark, press ctrl+e to enter the command prompt and type bm to create a bookmark ( is carriage return).

dschuyler avatar Aug 23 '17 02:08 dschuyler

Working on this. Should have a working implementation done sometime this week.

aaxu avatar Aug 24 '17 23:08 aaxu

What do you think about making bookmarks part of history? I'm thinking that it will be saved when user history is saved (so when the user saves the file with CTRL+S) and it's simply another entry in the fileHistory dictionary. We could get rid of bookmarks.py since I implemented all the bookmark functions inside text_buffer.py.

aaxu avatar Aug 25 '17 01:08 aaxu