blockly-samples icon indicating copy to clipboard operation
blockly-samples copied to clipboard

Update debug renderer for Q3 2021 core release

Open rachel-fenichel opened this issue 4 years ago • 1 comments

The debug renderer defined in the dev-tools package relies on the constant provider having created a debug filter during createDom.

In this commit in core I added a function createDebugFilter, but am still calling it from in createDom. It should only be created when the debugger is in use, so that call should come from outside of core.

Steps to fix:

  • Update core to make createDebugFilter public and get rid of the call to it in createDom
  • Update the debug renderer to call constantsProvider.createDebugFilter in the constructor
  • Publish the change to the debugger after the next publish of core

rachel-fenichel avatar Jul 23 '21 23:07 rachel-fenichel

Another option in core is to expose an addDef call on the constants provider, rather than exposing just createDebugFilter. That may be a better API--I held off on it since we're in the middle of goog.module work and I wanted to make a minimal change.

rachel-fenichel avatar Jul 23 '21 23:07 rachel-fenichel

@rachel-fenichel did this happen?

BeksOmega avatar May 16 '23 16:05 BeksOmega

Solved by deleting it.

rachel-fenichel avatar May 16 '23 17:05 rachel-fenichel