blockly-samples icon indicating copy to clipboard operation
blockly-samples copied to clipboard

Add script to automate checking for broken links within Samples

Open moniika opened this issue 3 years ago • 9 comments

Category

Plugins

Component

dev-scripts

Is your feature request related to a problem? Please describe.

In our READMEs, codelabs, and examples, we embed links to devsite. When documentation is rearranged in devsite (by refactoring folders in core or by rearranging/renaming pages) then the links become broken and need to be updated.

Describe the solution you'd like

A script that automatically checks if any links in our repo need to be fixed using a library like markdown-link-check or broken-link-checker. This would be useful to run after we update documentation as part of a Blockly core release, potentially using GitHub actions.

Describe alternatives you've considered

Same as current. Check whether links need to be fixed relevant codelabs/plugins/examples when we update documentation locations or update links when issues are filed.

Additional context

moniika avatar May 10 '21 23:05 moniika

Can I try this, some guidance on getting started would be appreciated. 😄

Harshita-Kanal avatar May 17 '21 20:05 Harshita-Kanal

Yup!

I think there are a few options here with varying levels of difficulty.

GitHub Action Ideally what we want is a GitHub action that runs every Thursday at 8am PST and creates an issue when it fails. The markdown-link-check above has a github action associated with it.

Potential steps:

This would be a great addition since we wouldn't have to trigger anything ourselves. However, it is a bit involved and we have limited experience with Github Actions so this route might be a bit bumpier and we wouldn't be able to help out as much.

Npm Script You could add a script to the repository that could be run by doing something like npm run publish:testLinks.

Potential steps:

I would consider either of these options as completing this issue, so feel free to work on whatever option you are interested in. Let us know if you have any other questions!

alschmiedt avatar May 18 '21 16:05 alschmiedt

I would like to work on this!

RamzahRehmanPAK avatar Sep 16 '22 17:09 RamzahRehmanPAK

Hi! I have mostly solved this problem but am encountering a small blocker. Can someone help, please? My issue is stated here.

Thanks!

SoumyaMukhija avatar Aug 20 '23 23:08 SoumyaMukhija

Heya @SoumyaMukhija just wondering if you're still working on this? Cool either way! Just want to check how it's going.

BeksOmega avatar Sep 05 '23 18:09 BeksOmega

@BeksOmega I am! I believe I am very close to a solution. I'll get back with an update soon. Thanks for assigning me!

SoumyaMukhija avatar Sep 05 '23 23:09 SoumyaMukhija

Can i work on this one? @BeksOmega

nidhidanayak avatar Sep 22 '23 17:09 nidhidanayak

@nidhidanayak I'm already working on it! Sorry!

SoumyaMukhija avatar Sep 22 '23 17:09 SoumyaMukhija

Hi, this issue has been fixed. Please review my PR at your earliest convenience!

SoumyaMukhija avatar Oct 04 '23 01:10 SoumyaMukhija